On Wed, Jun 18, 2014 at 10:39 PM, Matheus de Oliveira <matioli.matheus@gmail.com> wrote: > > I was going to answer each message, but Fabrízio summarized everything so far really nicely. Thanks Fabrízio. >
You're welcome. :-)
> > On Wed, Jun 18, 2014 at 5:25 PM, Fabrízio de Royes Mello <fabriziomello@gmail.com> wrote: >> >> Then, to summarize Matheus must do: >> * use an option instead of change the syntax and catalog to indicate that a tablespace is used to store temp objects > > > Yes. I myself wasn't sure TEMPORARY syntax would be good, but I would just like to hear more about. Storing as an options seems nice to me. >
Are there somebody that reject this idea? Thoughts?
>> >> * throw an exception if we try ALTER the option "only_temp_relations" > > > I think we should postpone the ALTER option, perhaps as another patch. Wasn't that what was decided? >
Don't worry about that, we can help you. ;-)
> > I'll investigate the options better before going this route. Let me work on CREATE first. >
See this files: - src/include/commands/tablespace.h (TableSpaceOpts struct at line 35) - src/backend/access/common/reloptions.c (tablespace_reloptions at line 1333)
>> >> * add regression tests >> * add documentation >> >> And, of course, register to the next open commitfest [1] to get detailed feedback and review. > > > Noted. It will be on the next commitfest. Just knowing some people do want this make me more comfortable on working better. >
