On 12/05/2013 06:53 PM, Tom Lane wrote: > I seem to remember that at some point we realized that the encoding > ID assignments are part of libpq's ABI and so can't practically be > changed ever, so the above may be moot. Even so, I think it's a > bad idea to be depending on pg_encoding_to_char() here, given the > ambiguity in what it references. It would be unsurprising to get > build-time or run-time failures on pickier platforms, as a > consequence of that ambiguity. So I'd still recommend comparing > integer IDs as above, rather than this.
Great feedback as always -- thanks! Will make that change.
Hi Joe, how are you?
Well, when Tom sent this email I was reviewing your patch and the main suggestion is about use of 'pg_encoding_to_char' too... ;-)
The attached patch with my review!
Regards,
--
Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL
