Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED - Mailing list pgsql-hackers

From Fabrízio de Royes Mello
Subject Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED
Date
Msg-id CAFcNs+oEGkmKDQfiF+GAWf4wGZ4UY_5P1QXrjXL6fb6AaLKKhw@mail.gmail.com
Whole thread Raw
In response to Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
<div dir="ltr"><div class="gmail_extra"><br />On Fri, Aug 22, 2014 at 4:45 PM, Alvaro Herrera <<a
href="mailto:alvherre@2ndquadrant.com">alvherre@2ndquadrant.com</a>>wrote:<br />><br />> BTW why is it that
index_build()checks the heap's relpersistence flag<br /> > rather than the index'?<br />><br /><br /></div><div
class="gmail_extra">I'mcurious about it too... the code in src/backend/catalog/index.c is:<br /><br />1975     if
(heapRelation->rd_rel->relpersistence== RELPERSISTENCE_UNLOGGED &&<br /> 1976        
!smgrexists(indexRelation->rd_smgr,INIT_FORKNUM))<br />1977     {<br /><br /></div><div class="gmail_extra"><br
/>Shouldnot to be in that way?<br /><br />1975     if (indexRelation->rd_rel->relpersistence ==
RELPERSISTENCE_UNLOGGED&&<br /> 1976         !smgrexists(indexRelation->rd_smgr, INIT_FORKNUM))<br
/>1977    {<br /><br /></div><div class="gmail_extra"><br />Alvaro, is this your concern? Right?<br /></div><div
class="gmail_extra"><br/></div><div class="gmail_extra"> Regards,<br /><br /></div><div class="gmail_extra">--<br
/>Fabríziode Royes Mello<br />Consultoria/Coaching PostgreSQL<br />>> Timbira: <a
href="http://www.timbira.com.br">http://www.timbira.com.br</a><br/>>> Blog: <a
href="http://fabriziomello.github.io">http://fabriziomello.github.io</a><br/> >> Linkedin: <a
href="http://br.linkedin.com/in/fabriziomello">http://br.linkedin.com/in/fabriziomello</a><br/>>> Twitter: <a
href="http://twitter.com/fabriziomello">http://twitter.com/fabriziomello</a><br/>>> Github: <a
href="http://github.com/fabriziomello">http://github.com/fabriziomello</a></div></div>

pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: WIP Patch for GROUPING SETS phase 1
Next
From: Tomas Vondra
Date:
Subject: Re: 9.5: Better memory accounting, towards memory-bounded HashAgg