Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED - Mailing list pgsql-hackers

On Fri, Aug 22, 2014 at 4:45 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
> BTW why is it that index_build() checks the heap's relpersistence flag
> rather than the index'?
>

I'm curious about it too... the code in src/backend/catalog/index.c is:

1975     if (heapRelation->rd_rel->relpersistence == RELPERSISTENCE_UNLOGGED &&
1976         !smgrexists(indexRelation->rd_smgr, INIT_FORKNUM))
1977     {

Should not to be in that way?

1975     if (indexRelation->rd_rel->relpersistence == RELPERSISTENCE_UNLOGGED &&
1976         !smgrexists(indexRelation->rd_smgr, INIT_FORKNUM))
1977     {

Alvaro, is this your concern? Right?

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello