Re: Support for array_remove and array_replace functions - Mailing list pgsql-hackers

From Alex Hunsaker
Subject Re: Support for array_remove and array_replace functions
Date
Msg-id CAFaPBrTxJQNJ_Hatt=J2dopGGMjwdTX=GVwER+7o4unCGM6N8Q@mail.gmail.com
Whole thread Raw
In response to Support for array_remove and array_replace functions  (Marco Nenciarini <marco.nenciarini@2ndquadrant.it>)
Responses Re: Support for array_remove and array_replace functions  (Marco Nenciarini <marco.nenciarini@2ndquadrant.it>)
List pgsql-hackers


On Thu, Jun 14, 2012 at 4:41 AM, Marco Nenciarini <marco.nenciarini@2ndquadrant.it> wrote:
Hi,

 following Gabriele's email regarding our previous patch on "Foreign
Key Arrays"[1], I am sending a subset of that patch which includes only
two array functions which will be needed in that patch: array_remove
(limited to single-dimensional arrays) and array_replace.
 
 The patch includes changes to the documentation.

Hi, I've been reviewing this patch.

Good documentation, and regression tests. The code looked fine but I didn't care for the code duplication between array_replace and array_remove so I merged those into a helper function, array_replace_internal(). Thoughts?

Other than that it all looks good to me.
Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: elog/ereport noreturn decoration
Next
From: Amit kapila
Date:
Subject: patch-3 (3-allow-wal-record-header-to-be-split.patch)WAL Format Changes