Re: SQL:2023 JSON simplified accessor support - Mailing list pgsql-hackers

From Matheus Alcantara
Subject Re: SQL:2023 JSON simplified accessor support
Date
Msg-id CAFY6G8cY5SUG5L-0ryVpom6HynE49p8-XQ59qkaEgnZZJ-c4Rg@mail.gmail.com
Whole thread Raw
In response to Re: SQL:2023 JSON simplified accessor support  (Alexandra Wang <alexandra.wang.oss@gmail.com>)
Responses Re: SQL:2023 JSON simplified accessor support
List pgsql-hackers
Hi Alex,

The code comments and the commit messages help a lot when reviewing! Thanks for
the new version.

The code LGTM and check-world is happy. I've also performed some tests and
everything looks good!

Just some minor points about this new version:

## v9-0005

Typo on commit message title

## v9-0006

> + * The following functions create various types of JsonPathParseItem nodes,
> + * which are used to build JsonPath expressions for jsonb simplified accessor.
>
Just to avoid misinterpretation I think that we can replace "The following
functions" with "The make_jsonpath_item_* functions" since we can have more
functions in the future that are not fully related with these. Does that make
sense?

-- 
Matheus Alcantara



pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Improve CRC32C performance on SSE4.2
Next
From: James Hunter
Date:
Subject: Re: int64 support in List API