GUC-ify walsender MAX_SEND_SIZE constant - Mailing list pgsql-hackers

From Majid Garoosi
Subject GUC-ify walsender MAX_SEND_SIZE constant
Date
Msg-id CAFWczPui3wpceYBez4Z9drTL+4-crmpn_LFnoRH4Pk0evSm2vw@mail.gmail.com
Whole thread Raw
Responses Re: GUC-ify walsender MAX_SEND_SIZE constant
Re: GUC-ify walsender MAX_SEND_SIZE constant
List pgsql-hackers
Hello all,

Following the threads here and there, I decided to submit this patch.

Following is the description which is also written in the commit message:
MAX_SEND_SIZE parameter was used in WALSender to limit maximum size of
a WAL data packet sent to a WALReceiver during replication. Although
its default value (128kB) was a reasonable value, it was written in
2010. Since the hardwares have changed a lot since then, a PostgreSQL
user might need to customize this value.
For example, if a database's disk has a high bandwidth and a high
latency at the same time, it makes more sense to read bigger chunks of
data from disk in each iteration. One example of such disks is a remote
disk. (e.g. an RBD volume)
However, this value does not need to be larger than wal_segment_size,
thus its checker function returns false if a larger value is set for
this.

This is my first patch. So, I hope I haven't done something wrong. :'D

Best regards
Majid
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Improving EXPLAIN's display of SubPlan nodes
Next
From: Nathan Bossart
Date:
Subject: Re: introduce dynamic shared memory registry