Re: [HACKERS] [patch] pg_dump/pg_restore zerror() and strerror() mishap - Mailing list pgsql-hackers

From Vladimir Kunschikov
Subject Re: [HACKERS] [patch] pg_dump/pg_restore zerror() and strerror() mishap
Date
Msg-id CAFWCTZa2o0xM9XFbKOPaWd=urONkCEmFimH9Dao474_q7P2ELg@mail.gmail.com
Whole thread Raw
In response to [HACKERS] [patch] pg_dump/pg_restore zerror() and strerror() mishap  (Kunshchikov Vladimir <Vladimir.Kunshchikov@infotecs.ru>)
Responses Re: [HACKERS] [patch] pg_dump/pg_restore zerror() and strerror()mishap
List pgsql-hackers
>This "maxlen" business and the fallback error message are
>strange.  We have roughly equivalent code in pg_basebackup.c
>which has been working since 2011
>Perhaps you can drop the memchr/fallback tricks and adopt the
>pg_basebackup coding?  Or is there a specific reason to have
>the memchr check?

Ofcourse that tricks can be dropped, function will be much prettier.
'Tricks' were made to pass some strict internal tests.
Initially I used exactly that function from pg_basebackup.c:
It was rewritten for the sake of somewhat exaggerated security.
Version #5 in attachment.

--
Regards,
Vladimir Kunschikov

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] segfault in HEAD when too many nested functions call
Next
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] [patch] pg_dump/pg_restore zerror() and strerror()mishap