Re: Add a filed to PageHeaderData - Mailing list pgsql-hackers

From Soroosh Sardari
Subject Re: Add a filed to PageHeaderData
Date
Msg-id CAFUsPDY=ekCuAsOZ=zuK8UJZrynmnVgbMyDTu28E9ZN1d+EUOA@mail.gmail.com
Whole thread
In response to Re: Add a filed to PageHeaderData  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers



On Tue, Jun 24, 2014 at 3:27 PM, Andres Freund <andres@2ndquadrant.com> wrote:
On 2014-06-24 15:23:54 +0430, Soroosh Sardari wrote:
> On Tue, Jun 24, 2014 at 2:40 PM, Kevin Grittner <kgrittn@ymail.com> wrote:
>
> > Soroosh Sardari <soroosh.sardari@gmail.com> wrote:
> >
> > > I check this problem with a virgin source code of
> > > postgresql-9.3.2. So the bug is not for my codes.
> >
> > > By the way, following code has two different output and it is
> > > weird.
> >
> > I can confirm that I see the difference in 9.3.2, and that I don't
> > see the difference in 9.3.4.  Upgrade.
> >
> > http://www.postgresql.org/support/versioning/
> >
> > There's really no point in reporting a possible bug on a version
> > with known bugs which have already had fixes published.
> >
> > --
> > Kevin Grittner
> > EDB: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
>
>
> wow, it's arch-dependent.
> in the 32-bit compiled of PG9.3.2 the code has same output and in 64-bit
> binary of same code output is different!!
>
> The problem is not about the sql code I posted in the last email. Problem
> could be different in any architecture,
> In 32-bit or 64-bit architecture adding a char array of length 20 to
> PageHeaderData cause error in regression test.

You likely didn't adapt SizeOfPageHederData.

Greetings,

Andres Freund

--
 Andres Freund                     http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services



#define SizeOfPageHeaderData (offsetof(PageHeaderData, pd_linp))

I think ,the macro does not need any change!

pgsql-hackers by date:

Previous
From: geohas
Date:
Subject: Re: Hooks Docu - list of hooks
Next
From: Robert Haas
Date:
Subject: Re: API change advice: Passing plan invalidation info from the rewriter into the planner?