Re: Bug in Database Nodes in the Tree - Mailing list pgadmin-hackers

From Yosry Muhammad
Subject Re: Bug in Database Nodes in the Tree
Date
Msg-id CAFSMqn9bkMR+qxz==9G+Q1KvQac15QTExb4WF3b8gCKxrha=rw@mail.gmail.com
Whole thread Raw
In response to Re: Bug in Database Nodes in the Tree  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: Bug in Database Nodes in the Tree  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Hi,

On Thu, Jul 18, 2019, 7:27 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Yosry,

On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad <yosrym93@gmail.com> wrote:
Hi Khushboo,

There's a minor bug that I noticed a while back that when you right click a disconnected database (to drop it for example) it automatically connects to the database and expands the node. This behaviour is a little annoying to users (me too), I am trying to fix it.

This behavior is by design as we have considered some of the pgAdmin III behavior. One behavior we can change is that on the selection of the database node, we can just connect it and not expand it and when we expand the database node (by arrow icon or double click), we can connect and expand both.

We need Dave's approval to change this.

I think this makes more sense.


I looked around the code in the browser module (node.js, database.js, menu.js) and I couldn't find a way to modify this behaviour. Is this handled internally by jQuery? Is modifying this behaviour feasible?
 
I think the problem is that the right click event triggers the left event click too. Am I correct?

Basically, the browser tree is generated through the aciTree library, so when required, the public APIs (provided by aciTree) of the events are being called.
In this case, on the selection of the database node, the selected event is used in the database.js file.

Thanks for the clarification. 

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: Bug in Database Nodes in the Tree
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Correct the issue number and sequence in release note