Postgres Pro
Downloads
Home   >   mailing lists

JavaScript Errors in the Query Tool Leads to a False Message - Mailing list pgadmin-hackers

From Yosry Muhammad
Subject JavaScript Errors in the Query Tool Leads to a False Message
Date
Msg-id CAFSMqn9DzqiERfw=_q=keq1rEdCJBnThjKjYXU4T4Ce_r03xrA@mail.gmail.com
Whole thread Raw
Responses Re: JavaScript Errors in the Query Tool Leads to a False Message  (Avin Kavish <avinkavish@gmail.com>)
List pgadmin-hackers
Tree view
Hi Hackers,

I have noticed a strange behavior in the JS code of the Query Tool. When a JS error occurs at any point during the execution of a query, the code is traced back to the last ajax call and goes to the catch portion (as if the ajax call failed). This leads to a "Not connected to the server" error message to the user, which is wrong.

I noticed this behavior before when fixing the bug where "Not connected to the server" message appeared when the user queries a column with no columns, which was due to a JS error being mistakenly identified as an ajax error.

Does anybody have any idea why this happens? This doesn't seem right.

Thanks.
Yosry Muhammad Yosry

Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Query Tool Slow to Load
Next
From: Yosry Muhammad
Date:
Subject: [GSoC] Query History Integration with updatable query resultsets and improvements