This breaks the reconnect for query tool. Open a query tool, execute some query and then restart the python server. Go to the query tool and click execute. It will show a warning, on continuing it should connect again. It throws exception in browser console:
Uncaught TypeError: Cannot read property 'apply' of undefined at Object.eval (VM69935 sqleditor.js:1769) at Object.callback (alertify.js:3347) at triggerCallback (alertify.js:1220) at Object.buttonsClickHandler (alertify.js:1241) at HTMLDivElement.eval (alertify.js:299)
On Thu, Aug 22, 2019 at 11:44 PM Yosry Muhammad <yosrym93@gmail.com> wrote:
Please find an updated patch attached.
On Mon, Aug 19, 2019 at 9:54 AM Yosry Muhammad <yosrym93@gmail.com> wrote:
Jasmine tests passed on my machine, I will take another look once I have access to my machine.