Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React - Mailing list pgadmin-hackers

From Matthew Kleiman
Subject Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React
Date
Msg-id CAFS4TJapVubRP_BK01GwYjfN7zpaTbCMX+CROC4mV93aL08DOg@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React
List pgadmin-hackers
Dave,

Can you try running grunt tests on the command line? 

The tests task will run the eslint and karma grunt tasks, which should automatically webpack the React components before running the jasmine tests in karma.

If it still fails, send us the output of that.

Thanks,
Matt

On Thu, May 18, 2017 at 5:31 AM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, May 18, 2017 at 9:56 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Go to 'pgadmin4/web' directory

Try running,

run 'yarn install'

(if you have installed globally)
then run 'grunt' 
OR
run './node_modules/grunt-cli/bin/grunt'


Then run pgAdmin4

OK, that worked - though pgAdmin now takes a lot longer to start up, which is a problem.

The Jasmine tests now fail:

(pgadmin4)piranha:web dpage$ yarn run karma start --single-run
yarn run v0.24.4
$ "/Users/dpage/git/pgadmin4/web/node_modules/.bin/karma" start
18 05 2017 10:22:01.182:ERROR [plugin]: Error during loading "karma-phantomjs-launcher" plugin:
  Path must be a string. Received null

webpack: Compiled successfully.
webpack: Compiling...
webpack: wait until bundle finished: 
webpack: wait until bundle finished: 
webpack: wait until bundle finished: 
webpack: wait until bundle finished: 
webpack: wait until bundle finished: 
webpack: wait until bundle finished: 
webpack: wait until bundle finished: 
webpack: wait until bundle finished: 
webpack: wait until bundle finished: 
webpack: wait until bundle finished: 
webpack: wait until bundle finished: 
webpack: wait until bundle finished: 
(node:12214) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
18 05 2017 10:22:07.281:WARN [karma]: No captured browser, open http://localhost:9876/

webpack: Compiled successfully.
18 05 2017 10:22:07.294:ERROR [karma]: Found 1 load error
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. 



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Shirley Wang
Date:
Subject: Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4
Next
From: Shirley Wang
Date:
Subject: Re: [pgadmin-hackers] Declarative partitioning in pgAdmin4