Re: [PATCH] add concurrent_abort callback for output plugin - Mailing list pgsql-hackers

From Ajin Cherian
Subject Re: [PATCH] add concurrent_abort callback for output plugin
Date
Msg-id CAFPTHDacfWdbM9Zgbfv+DuYh=-Au+KPSc8VDqpkdRxHBg9zVbA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] add concurrent_abort callback for output plugin  (Markus Wanner <markus.wanner@enterprisedb.com>)
List pgsql-hackers


On Wed, Mar 31, 2021 at 5:25 PM Markus Wanner <markus.wanner@enterprisedb.com> wrote:

The last sentences there now seems to relate to just the setting of
"concurrent_abort", rather than the whole reason to invoke the
prepare_cb.  And the reference to the "gid" is a bit lost.  Maybe:

    "Thus even in case of a concurrent abort, enough information is
     provided to the output plugin for it to properly deal with the
     <command>ROLLBACK PREPARED</command> once that is decoded."

Alternatively, state that the gid is otherwise missing earlier in the
docs (similar to how the commit message describes it).


I'm fine with Amit's changes and like Markus's last suggestion as well.

regards,
Ajin Cherian
Fujitsu Australia
 

pgsql-hackers by date:

Previous
From: Ajin Cherian
Date:
Subject: Re: locking [user] catalog tables vs 2pc vs logical rep
Next
From: "Joel Jacobson"
Date:
Subject: Re: Idea: Avoid JOINs by using path expressions to follow FKs