Re: Race condition in FetchTableStates() breaks synchronization of subscription tables - Mailing list pgsql-hackers

From Ajin Cherian
Subject Re: Race condition in FetchTableStates() breaks synchronization of subscription tables
Date
Msg-id CAFPTHDY1H1dRp_QkREYWCcUevPT2xXYJfqzFdQ8EL=+befipeA@mail.gmail.com
Whole thread Raw
In response to Re: Race condition in FetchTableStates() breaks synchronization of subscription tables  (vignesh C <vignesh21@gmail.com>)
Responses Re: Race condition in FetchTableStates() breaks synchronization of subscription tables
List pgsql-hackers


On Tue, Mar 12, 2024 at 2:59 PM vignesh C <vignesh21@gmail.com> wrote:

Thanks, I have created the following Commitfest entry for this:
https://commitfest.postgresql.org/47/4816/

Regards,
Vignesh

Thanks for the patch, I have verified that the fix works well by following the steps mentioned to reproduce the problem. 
Reviewing the patch, it seems good and is well documented. Just one minor comment I had was probably to change the name of the variable table_states_valid to table_states_validity. The current name made sense when it was a bool, but now that it is a tri-state enum, it doesn't fit well.

regards,
Ajin Cherian
Fujitsu Australia

pgsql-hackers by date:

Previous
From: "Jingxian Li"
Date:
Subject: Re: [PATCH] LockAcquireExtended improvement
Next
From: Oleg Tselebrovskiy
Date:
Subject: Re: [PROPOSAL] Skip test citext_utf8 on Windows