Re: [pgAdmin4] [Patch]: Foreign Table Module - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin4] [Patch]: Foreign Table Module
Date
Msg-id CAFOhELfm9y9jQLLzvnQpKey5TX=yZkL+qaF=6g+CsvuWKFDh2w@mail.gmail.com
Whole thread Raw
In response to [pgAdmin4] [Patch]: Foreign Table Module  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: [pgAdmin4] [Patch]: Foreign Table Module
List pgadmin-hackers
Hi,

I have updated the Foreign Table module as below:

- Used 'NodeByListControl' to get schemas, in the foreign_table.js file as suggested by Ashesh to avoid code redundancy.

- Applied 'Security Label Macro'  Patch (Implemented by Harshal).
  To test the Foreign Table patch, 'Security Label Macro' patch must be applied first as that is not committed yet.

Please find attached Foreign Table Patch.

Thanks,
Khushboo

On Tue, Feb 23, 2016 at 6:53 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find attached patch for the Foreign Table Module.

The patch will be modified after Types module implementation as we need to populate Base Type  and some Type related validations from the Types module.

Please review it and let me know the feedback.

Thanks,
Khushboo

Attachment

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: pgAdmin4 PATCH: Domain Module
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin 4 commit: Resolved a typo in the node creation SQL template for