Postgres Pro
Downloads
Home   >   mailing lists

Re: Re- [RM-3669]If user drop any object and click on create script,count rows and Truncate table, proper error should displayed that object isin present - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: Re- [RM-3669]If user drop any object and click on create script,count rows and Truncate table, proper error should displayed that object isin present
Date
Msg-id CAFOhELeFcAhPZNgCJiDg0DhVxnHGuts66xh2fHc_p_Du132CTQ@mail.gmail.com
Whole thread Raw
In response to Re: Re- [RM-3669]If user drop any object and click on create script,count rows and Truncate table, proper error should displayed that object isin present  (Satish V <satish.v@enterprisedb.com>)
Responses Re: Re- [RM-3669]If user drop any object and click on create script,count rows and Truncate table, proper error should displayed that object isin present  (Satish V <satish.v@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Satish,

- On failure, you have added a new condition if (e.status == 410) at some places, this is not necessary as we have generalised code for that. 
- Please maintain the consistency in messages, you can check the GONE message template, we do have them at some places. (Example: on Database expansion )
- Please follow basic JS coding standards. Ex: A space is required after/before any operator. I have seen 1 or 2 places where a space is missing in your patch.

Thanks,
Khushboo

On Tue, Jun 2, 2020 at 12:45 PM Satish V <satish.v@enterprisedb.com> wrote:
Hi Kushboo,

All the menus for all the deleted nodes were handled except Maintenance, backup /restore, import/export.

Scripts,Refers View,View/Edit data and Create- child nodes for any parent node which is deleted are handled.
Refresh, Delete/drop,drop cascade and properties were already handled for all the nodes. So i didn't make changes to them as they are displaying proper error messages already and I checked it for all the nodes.


Thanks
Sathish V

On Tue, Jun 2, 2020 at 12:22 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Satish,

On Mon, Jun 1, 2020 at 2:16 PM Satish V <satish.v@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch which alerts the users when they try to consume the options in the context menu of the deleted node.
Can you please specify the context menu options which you handled, so it will be easy for me to review.

Thanks,
Khushboo
-fixed the opening of an empty query tool window for non existing nodes.(create/delete/update..)
- handles the error like "list index out of range" with a reasonable error dialog or alert.
 
Kindly review the patch and let me know of the changes required.


Thanks,
Sathish V

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: The 'pwd' module is not available on Windows, so repl
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Include postgresql-libs in our Yum repos.