Re: [pgAdmin][RM2172] Search Objects Functionality - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin][RM2172] Search Objects Functionality
Date
Msg-id CAFOhELe2TdP4z-+g_UV-k8fk9CeKtTq_sBKiepdSjdNKHgDopw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM2172] Search Objects Functionality  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: [pgAdmin][RM2172] Search Objects Functionality  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Hi Aditya,

Review comments:

UI:

1. When no object is found, the default message should be given, currently no message displayed.
2. Can we have a tooltip on the row "Double click to locate the object in the browser" ?
3. Full stop is missing in the message column objects are disabled in the browser. You can enable them in the preferences dialog ( :D )
and also, we should start the statement with the capital letter.
4. If possible, use the multilevel partition table symbol same as the browser tree.
5. gettext is missing from the search grid header.
6. Suggestion: The search button should be at the end (after type combobox).  The current position of the controls suggest that search for the objects and then filter it out but that's not the case.
After changing the type, we have to click on the search button.
In the current positioning, we should fetch all the records from the backend and then filter those out depending on the type at the client side only, so that will reduce the server requests and slickgrid is efficient it do so.

Backend:

1. We do have the list of blueprint, so we can use that list instead of taking the hard coe list in the init method of SearchObjectsHelper class.
2. While searching the object, we create an object of SearchObjectsHelper on each request. We can create it once while initializing and utilize it on every search.

Note: The functionality is working fine.

Thanks,
Khushboo




On Thu, Apr 2, 2020 at 9:31 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Wed, Apr 1, 2020 at 6:00 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo,

Can you please review it.
I am on it. 

On Mon, Mar 30, 2020 at 2:39 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to implement search objects functionality in pgadmin.
The feature will allow a user to search for any object in a database.
Highlights of the feature:
1) Search any object with user input text with at least 3 characters.
2) Search can be done on a specific object type by selecting from the types dropdown.
3) The search results grid will show object name, object type and the object path on the browser tree. On double clicking the record, it will locate that object on the browser tree. The columns object name and type are sortable.
4) The object nodes which are disabled (hidden) using preferences will not be visible in the types dropdown. However, in the case of all types, the search records will be visible for those types greyed out.
5) You can also access search objects dialog using the button on the browser toolbar.

Python and JS test cases added. Docs updated.
Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Tag REL-4_20 has been created.
Next
From: Aditya Toshniwal
Date:
Subject: Re: [pgAdmin][RM2172] Search Objects Functionality