Re: [pgAdmin4][Patch]: RM - 3051 - ables > Properties > Columns tab is slow on tables with a lot of fields - Mailing list pgadmin-hackers
Hi Aditya,
Thanks for the review.
Please find the attached updated patch.
@ Murtuza,
Regarding your concern, I have not used the API. As per the documentation, there are 2 ways to initialise the bootstrap toggle, First Initialise with HTML and second with Code.
In our case, Initialisation with HTML is not possible as we render the backform controls runtime, So, I have used the other option.
Also, the main issue of slow rendering which has been solved through this implementation. The browser hanging issue is due to Backbone collection reset method and I am working on that part with another RM, https://redmine.postgresql.org/issues/3664.
@ Dave,
Please, review this patch, we need your approval for the toggle design changes.
Thanks,
Khushboo
On Tue, Jan 22, 2019 at 11:33 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Khushboo,I have few suggestions/review:1) Do we need to add "editor" class to switch control in backgrid when changing. For eg. in tables->columns if I change not null switch, it adds editor class which makes hover background white. Plus, leaving the switch does not remove editor class. I think we can skip adding editor, what do you think?
This issue was old, not due to my patch but I have fixed it.
2) In Login roles, Create trigger dialogs switch control colors are different. Below is screenshot,
Fixed
3) In Create cast dialog switch control is smaller and so clipping text. Below is screenshot,
Fixed
4) You've removed unnecessary switch control template codes at most places. I would suggest doing the same for Backform.CustomSwitchControl in trigger.js
Done
5) Feature tests are still using bootstrap-switch classes and so failing.
Fixed
Apart from above, everything looks good to me.On Mon, Jan 21, 2019 at 4:42 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaCan you please review it.On Mon, Jan 14, 2019 at 4:28 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hi,Please find the attached patch to fix #3051 - Tables > Properties > Columns tab is slow on tables with a lot of fieldsThe root cause of the issue is bootstrap switch, which has been replaced with bootstrap4-toggle application wide.Thanks,Khushboo--Akshay JoshiSr. Software ArchitectPhone: +91 20-3058-9517
Mobile: +91 976-788-8246--Thanks and Regards,Aditya ToshniwalSoftware Engineer | EnterpriseDB Software Solutions | Pune"Don't Complain about Heat, Plant a tree"
Attachment
pgadmin-hackers by date: