Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object. - Mailing list pgadmin-hackers
From | Khushboo Vashi |
---|---|
Subject | Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object. |
Date | |
Msg-id | CAFOhELdv_EFFctXmLNVTeH4dj7EdQ_oabAUxeC+oho+S4Q-Jww@mail.gmail.com Whole thread Raw |
In response to | Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object. (Dave Page <dpage@pgadmin.org>) |
Responses |
Re: [pgAdmin4][Patch]: RM #2963 - Backup database, Restore database and Maintenance Database failed for é object.
|
List | pgadmin-hackers |
Hi,
Please find the attached patch to fix below issues:
1. #2963 - Backup database, Restore database and Maintenance Database failed for é object
2. #3157 - Process viewer doesn't show complete command executed.
Test cases are not included for these fixes as we don't have test cases for these modules (backup, restore, maintenance).
I will create one separate RM for the same which will cover this.
Thanks,
Khushboo
On Fri, Jan 12, 2018 at 3:24 PM, Dave Page <dpage@pgadmin.org> wrote:
HiOn Wed, Jan 10, 2018 at 6:59 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: On Wed, Jan 3, 2018 at 8:54 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Mon, Dec 25, 2017 at 11:03 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote: Hi,Please find the attached patch to fix RM #2963: Backup database, Restore database and Maintenance Database failed for é object.With the patch applied, I get:2018-01-03 15:23:00,110: INFO pgadmin: Executing the process executor with the arguments: ['/Users/dpage/.virtualenvs/pgadmin4/bin/python', '/Users/dpage/git/pgadmin4/web /pgadmin/misc/bgprocess/proces s_executor.py', '/usr/local/pgsql/bin/pg_dump' , u'--file', u'/Users/dpage/e.sql', u'--host', u'localhost', u'--port', '5432', u'--username', u'postgres', u'--no-password', u'--verbose', u'--format=c', u'--blobs', u'\xe9'] 2018-01-03 15:23:00,117: INFO werkzeug: 127.0.0.1 - - [03/Jan/2018 15:23:00] "POST /backup/job/1/object HTTP/1.1" 200 -Exception in thread Thread-6:Traceback (most recent call last):File "/System/Library/Frameworks/Python.framework/Versions/2.7/li b/python2.7/threading.py", line 810, in __bootstrap_inner self.run()File "/System/Library/Frameworks/Python.framework/Versions/2.7/li b/python2.7/threading.py", line 763, in run self.__target(*self.__args, **self.__kwargs)File "/System/Library/Frameworks/Python.framework/Versions/2.7/li b/python2.7/SocketServer.py", line 602, in process_request_thread self.handle_error(request, client_address)File "/System/Library/Frameworks/Python.framework/Versions/2.7/li b/python2.7/SocketServer.py", line 599, in process_request_thread self.finish_request(request, client_address)File "/System/Library/Frameworks/Python.framework/Versions/2.7/li b/python2.7/SocketServer.py", line 334, in finish_request self.RequestHandlerClass(request, client_address, self) File "/System/Library/Frameworks/Python.framework/Versions/2.7/li b/python2.7/SocketServer.py", line 655, in __init__ self.handle()File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/werkzeug/serving.py", line 200, in handle rv = BaseHTTPRequestHandler.handle(self) File "/System/Library/Frameworks/Python.framework/Versions/2.7/li b/python2.7/BaseHTTPServer.py" , line 340, in handle self.handle_one_request()File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/werkzeug/serving.py", line 235, in handle_one_request return self.run_wsgi()File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/werkzeug/serving.py", line 177, in run_wsgi execute(self.server.app)File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/werkzeug/serving.py", line 165, in execute application_iter = app(environ, start_response)File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/flask/app.py", line 2000, in __call__ return self.wsgi_app(environ, start_response)File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/flask/app.py", line 1991, in wsgi_app response = self.make_response(self.handle_exception(e)) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/flask/app.py", line 1567, in handle_exception reraise(exc_type, exc_value, tb)File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/flask/app.py", line 1988, in wsgi_app response = self.full_dispatch_request()File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/flask/app.py", line 1641, in full_dispatch_request rv = self.handle_user_exception(e)File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/flask/app.py", line 1544, in handle_user_exception reraise(exc_type, exc_value, tb)File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/flask/app.py", line 1639, in full_dispatch_request rv = self.dispatch_request()File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/flask/app.py", line 1625, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packa ges/flask_login.py", line 792, in decorated_view return func(*args, **kwargs)File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/__init __.py", line 62, in index return make_response(response=BatchProcess.list()) File "/Users/dpage/git/pgadmin4/web/pgadmin/misc/bgprocess/proces ses.py", line 512, in list desc = loads(p.desc)File "/System/Library/Frameworks/Python.framework/Versions/2.7/li b/python2.7/pickle.py", line 1381, in loads file = StringIO(str)UnicodeEncodeError: 'ascii' codec can't encode character u'\ufffd' in position 138: ordinal not in range(128)Fixed. Please find the attached updated patch.That's getting further, but still not right. Please see the attached screenshot - the beginning of the executed command has been lost.--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
pgadmin-hackers by date: