Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFEsupport for functions missing - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFEsupport for functions missing
Date
Msg-id CAFOhELdfheYVqBeW_7M1_gnS-cw=HhYd7sJffc6F8ittP0moog@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFEsupport for functions missing  (Dave Page <dave.page@enterprisedb.com>)
Responses Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFEsupport for functions missing
List pgadmin-hackers


On Fri, Feb 3, 2017 at 7:02 PM, Dave Page <dave.page@enterprisedb.com> wrote:
I doubt the order matters, but feel free to change it if it bugs you :-)


I have tried to create the function with both SQL commands. 
There is no bug, its just in pgAdmin4, if its not leakproof then we mentioned 'NOT LEAKPROOF'  in the SQL.
So, I am not sure, we should remove it or not.

On Fri, Feb 3, 2017 at 12:54 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave 

I have reviewed the patch and after applying it output in pgAdmin4  

CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 geometry)
    RETURNS boolean
    LANGUAGE 'sql'
    COST 100.0
    IMMUTABLE NOT LEAKPROOF 
    PARALLEL SAFE
AS $function$
SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2)
$function$;

but as per psql it should be 

CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 geometry)

 RETURNS boolean

 LANGUAGE sql

 IMMUTABLE PARALLEL SAFE

AS $function$SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2)$function$


is this behaviour correct??



On Fri, Feb 3, 2017 at 5:31 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix RM 2089 : PARALLEL SAFE support for functions missing.

Fix: Incorporated the  PARALLEL SAFE support for the functions and procedures for PostgreSQL 9.6.

Thanks,
Khushboo



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Akshay Joshi
Principal Software Engineer 





--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue in handlingof timestamp type
Next
From: Dave Page
Date:
Subject: [pgadmin-hackers] pgAdmin 4 commit: Handle saved directories that no longer existgracefu