Re: [pgadmin4] Edb package support. - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgadmin4] Edb package support.
Date
Msg-id CAFOhELdX6H59Tm+D+rKe9iSL4V2GJ4AHXYyHsmDRVJwu2eQz+g@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin4] Edb package support.  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin4] Edb package support.  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
List pgadmin-hackers


On Wed, Aug 17, 2016 at 4:35 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi,

I did some quick testing, and found the following issues:

- Package ACL is not shown in properties

- Package header and body are not shown in properties

- System package? is not shown in properties

- The header for the RE SQL on a package procedure should read:

-- Package Procedure

(not -- Package Function)

Can you also have someone (Khushboo?) do a code review, if that hasn't
happened already?


Sure, will do this.
 
Thanks.

On Tue, Aug 16, 2016 at 1:31 PM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PFA initial patch for edb packages.
>
> Other changes:
> 1] Added 'canEdit' flag for node to enable/disabled node edit. (by default
> it's enable)
> 2] Privileges: Do not show 'ALL' in query if object has only one applicable
> privilege instead show that privilege.
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Debugger]: Fix RM-1224
Next
From: Murtuza Zabuawala
Date:
Subject: PATCH: To fix the issue in configuration error message (pgAdmin4)