Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger thanunderlying field size - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger thanunderlying field size
Date
Msg-id CAFOhELdUp98fKpMDr2NF4US_j0nNTN5=Rnz4LY0rcUmFVzkZpw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][RM5210] pgAdmin4 silently truncates text larger thanunderlying field size  (navnath gadakh <navnath.gadakh@enterprisedb.com>)
Responses Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger thanunderlying field size  (navnath gadakh <navnath.gadakh@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Navnath,

You have compared the column's internal size with the length of the value given by the user.
For example, column having integer would have internal size 4 and if I give the value 12121 which is the correct input for the field will fail here because as per your logic column internal size (4) < len(value) (5).

I think this implementation is not correct here.

Thanks,
Khushboo



On Tue, Apr 14, 2020 at 4:33 PM navnath gadakh <navnath.gadakh@enterprisedb.com> wrote:
Hello Hackers,
Please find the attached patch for below fixes:

- Added validation for table row data that should not be larger than the field size.
- Rearrange the existing functions to add validation.
- Added test cases.

Regards,
Navnath Gadakh

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: Re: RM4292 - Dark mode support for Windows/macOS
Next
From: Ganesh Jaybhay
Date:
Subject: [pgAdmin][4709] Invalid FTS configuration token dictionaries