Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tableswith OIDs but no primary key - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tableswith OIDs but no primary key
Date
Msg-id CAFOhELcY5YP5As57S5Czgs7kq6eEtpw1Kq_jJDeCV6838Qvh+Q@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tableswith OIDs but no primary key  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key
List pgadmin-hackers
Tree view
Hi,

Please find the attached updated patch.

On Mon, Nov 27, 2017 at 5:15 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Nov 23, 2017 at 1:28 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for RM #2849: Allow editing of data on tables with OIDs but no primary key.

I like that if I add a new row or rows and hit Save, the OIDs are fetched immediately. However;

- It marks the row as read-only. We do that currently because we don't return the key info on Save, and thus require a Refresh before any further editing. However, if we have the OID, we can edit again immediately.

Fixed 
- If we can return the new OIDs on Save, can't we do the same for primary key values? That would be consistent with OIDs, and would remove the need to disable rows, leading to a much nicer use experience I think.

Implemented 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thanks,
Khushboo
Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Patch for pgAdmin docs (role_dialog.rst, resource_group_dialog.rst)
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Doc updates for resource groups and roles.