[HACKERS] Improve logical decoding error message (was wal_level > WAL_LEVEL_LOGICAL) - Mailing list pgsql-hackers

From Neha Khatri
Subject [HACKERS] Improve logical decoding error message (was wal_level > WAL_LEVEL_LOGICAL)
Date
Msg-id CAFO0U+_y8AyAcQLiF3S1i6yCNuYrcLNEd-BbzCuHiGOSejW=2A@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] Improve logical decoding error message (was wal_level > WAL_LEVEL_LOGICAL)  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Mon, May 22, 2017 at 11:08 PM, Neha Khatri <nehakhatri5@gmail.com> wrote:
As per my understabding, current postgres server supports only three
values for wal_level i.e. 'minimal' , 'replica' or 'logical'. But
following error message brought to notice that there are various code
spots that try to look for wal_level >= WAL_LEVEL_LOGICAL:

  select * from pg_create_logical_replication_slot('regression_slot',
'test_decoding');
  ERROR:  logical decoding requires wal_level >= logical

The Logical Decoding example in the documentation says:

  "Before you can use logical decoding, you must set wal_level to logical and max_replication_slots to at least 1."

But above error message is not exactly consistent with this documentation. Would it make sense to keep the error message and the documentation consistent like the attached.

Regards,
Neha
Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] PG10 Crash-safe and replicable Hash Indexes and UNIQUE
Next
From: Mark Rofail
Date:
Subject: [HACKERS] GSoC 2017: Foreign Key Arrays