Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] strange parallel query behavior after OOM crashes - Mailing list pgsql-hackers

From Neha Khatri
Subject Re: [HACKERS] strange parallel query behavior after OOM crashes
Date
Msg-id CAFO0U+_FfXGyyKL723+-UCXXbiG485CPKE5v__nwKwkDnzcaeA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] strange parallel query behavior after OOM crashes  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] strange parallel query behavior after OOM crashes  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view
On Tue, Apr 11, 2017 at 1:16 AM, Robert Haas <robertmhaas@gmail.com> wrote:

1. Forget BGW_NEVER_RESTART workers in
ResetBackgroundWorkerCrashTimes() rather than leaving them around to
be cleaned up after the conclusion of the restart, so that they go
away before rather than after shared memory is reset.

Now with this, would it still be required to forget BGW_NEVER_RESTART workers in maybe_start_bgworker():

                if (rw->rw_crashed_at != 0)
{
if (rw->rw_worker.bgw_restart_time == BGW_NEVER_RESTART)
{
ForgetBackgroundWorker(&iter);
continue;
}
                     ......
                }

Regards,
Neha

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [HACKERS] Some thoughts about SCRAM implementation
Next
From: Álvaro Hernández Tortosa
Date:
Subject: Re: [HACKERS] Letting the client choose the protocol to use during aSASL exchange