Re: build remaining Flex files standalone - Mailing list pgsql-hackers

From John Naylor
Subject Re: build remaining Flex files standalone
Date
Msg-id CAFBsxsHdAP0U3AjYuJ_SpWBxj2vmpdqXX3Yg=TLBrq0rAWhFgg@mail.gmail.com
Whole thread Raw
In response to Re: build remaining Flex files standalone  (John Naylor <john.naylor@enterprisedb.com>)
Responses Re: build remaining Flex files standalone
Re: build remaining Flex files standalone
List pgsql-hackers
> > > > > index dbe7d4f742..0b373048b5 100644
> > > > > --- a/contrib/cube/cubedata.h
> > > > > +++ b/contrib/cube/cubedata.h
> > > > > @@ -67,3 +67,7 @@ extern void cube_scanner_finish(void);
> > > > >
> > > > >  /* in cubeparse.y */
> > > > >  extern int   cube_yyparse(NDBOX **result);
> > > > > +
> > > > > +/* All grammar constructs return strings */
> > > > > +#define YYSTYPE char *
> > > >
> > > > Why does this need to be defined in a semi-public header? If we do this in
> > > > multiple files we'll end up with the danger of macro redefinition warnings.
>
> For v4, I #defined YYSTYPE

Sorry for the misfire. Continuing on, I #defined YYSTYPE in cubescan.l
before #including cubeparse.h.

I also added scanbuflen to the %parse-param to prevent resorting to a
global variable. The rest of the patches are unchanged.

-- 
John Naylor
EDB: http://www.enterprisedb.com

Attachment

pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: Re: build remaining Flex files standalone
Next
From: John Naylor
Date:
Subject: Re: build remaining Flex files standalone