Re: Incorrect include file order in guc-file.l - Mailing list pgsql-hackers

From John Naylor
Subject Re: Incorrect include file order in guc-file.l
Date
Msg-id CAFBsxsHcg6WM339jmtg8_y2efwG_9eK-BCd1MUMmZet6KcPx0A@mail.gmail.com
Whole thread Raw
In response to Re: Incorrect include file order in guc-file.l  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Incorrect include file order in guc-file.l
List pgsql-hackers


On Thu, Nov 3, 2022 at 6:40 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Nov 03, 2022 at 12:40:19PM +0700, John Naylor wrote:
> > On Wed, Nov 2, 2022 at 1:01 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
> >> Agreed, it's apparently an oversight in dac048f71eb.  +1 for the patch.
> >
> > I've pushed this, thanks!
>
> Thanks for the commit.  I've wanted to get it done yesterday but life
> took over faster than that.  Before committing the change, there is
> something I have noticed though: this header does not seem to be
> necessary at all and it looks that there is nothing in guc-file.l that
> needs it.  Why did you add it in dac048f to begin with?

Because it wouldn't compile otherwise, obviously. :-)

I must have been working on it before bfb9dfd93720

--
John Naylor
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Commit fest 2022-11
Next
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: Perform streaming logical transactions by background workers and parallel apply