Postgres Pro
Downloads
Home   >   mailing lists

Re: Incorrect include file order in guc-file.l - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Incorrect include file order in guc-file.l
Date
Msg-id Y2OosGi1Xh9x/lEn@paquier.xyz
Whole thread Raw
In response to Re: Incorrect include file order in guc-file.l  (John Naylor <john.naylor@enterprisedb.com>)
Responses Re: Incorrect include file order in guc-file.l
List pgsql-hackers
Tree view 
On Thu, Nov 03, 2022 at 12:40:19PM +0700, John Naylor wrote:
> On Wed, Nov 2, 2022 at 1:01 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
>> Agreed, it's apparently an oversight in dac048f71eb.  +1 for the patch.
>
> I've pushed this, thanks!

Thanks for the commit.  I've wanted to get it done yesterday but life
took over faster than that.  Before committing the change, there is
something I have noticed though: this header does not seem to be
necessary at all and it looks that there is nothing in guc-file.l that
needs it.  Why did you add it in dac048f to begin with?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: David Geier
Date:
Subject: Add explicit casts in four places to simplehash.h
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Add native windows on arm64 support