On Wed, Oct 07, 2020 at 03:18:44PM +0900, Michael Paquier wrote: I looked at this one again today, and applied it. I looked at what MSVC compiler was able to do in terms of optimizationswith shift-and-add for multipliers, and it is by far not as good as gcc or clang, applying imul for basically all the primes we could use for the perfect hash generation.
Thanks for picking this up! As I recall, godbolt.org also showed MSVC unable to do this optimization.
> I have tested 0002 and 0003, that had better be merged together at the > end, and I can see performance improvements with MSVC and gcc similar > to what is being reported upthread, with 20~30% gains for simple > data sample using IS NFC/NFKC. That's cool.
For these two, I have merged both together and did some adjustments as per the attached. Not many tweaks, mainly some more comments for the unicode header files as the number of structures generated gets higher.
Looks fine overall, but one minor nit: I'm curious why you made a separate section in the pgindent exclusions. The style in that file seems to be one comment per category.
