Re: pgsql: Fix perltidy breaking perlcritic - Mailing list pgsql-committers

From John Naylor
Subject Re: pgsql: Fix perltidy breaking perlcritic
Date
Msg-id CAFBsxsGfpcxgnsJ2CoM+k7uWsMoNXXgqjRmOQBrxGeehw0oFgA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Fix perltidy breaking perlcritic  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
List pgsql-committers
On Mon, Sep 12, 2022 at 4:54 PM Dagfinn Ilmari Mannsåker
<ilmari@ilmari.org> wrote:

> > eval "\$hash_ref = $_";  ## no critic (ProhibitStringyEval)
>
> I didn't see this until it got committed, since I'm not subscribed to
> -committers, but I think it would be even better to rely on the fact
> that eval returns the value of the last expression in the string, which
> also gets rid of the ugly quoting and escaping, per the attached.

Hmm, interesting.
--
John Naylor
EDB: http://www.enterprisedb.com



pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: pgsql: Treat Unicode codepoints of category "Format" as non-spacing
Next
From: John Naylor
Date:
Subject: pgsql: Adjust header exceptions for 0bd9c6297