Re: speed up unicode normalization quick check - Mailing list pgsql-hackers

From John Naylor
Subject Re: speed up unicode normalization quick check
Date
Msg-id CAFBsxsGfJcFBMayaqHvRZ1izRZEoSY=Xy646r5A792uRYAq+bg@mail.gmail.com
Whole thread Raw
In response to Re: speed up unicode normalization quick check  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: speed up unicode normalization quick check  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


On Mon, Oct 19, 2020 at 2:16 AM Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
On 2020-10-12 13:36, Michael Paquier wrote:
> On Mon, Oct 12, 2020 at 03:39:51PM +0900, Masahiko Sawada wrote:
>> Yes, this patch resolves the problem.
>
> Okay, applied then.

Could you adjust the generation script so that the resulting header file
passes the git whitespace check?  Check the output of

git show --check 80f8eb79e24d9b7963eaf17ce846667e2c6b6e6f

My git manual says:

"By default, trailing
whitespaces (including lines that consist solely of
whitespaces) and a space character that is immediately
followed by a tab character inside the initial indent of the
line are considered whitespace errors."

The above would mean we should have errors for every function whose parameters are lined with the opening paren, so I don't see why it would fire in this case. Is the manual backwards?

--
John Naylor
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company 

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Is Recovery actually paused?
Next
From: Pierre Giraud
Date:
Subject: Re: [PATCH] Add extra statistics to explain for Nested Loop