Re: pgsql: Fix perltidy breaking perlcritic - Mailing list pgsql-committers

From John Naylor
Subject Re: pgsql: Fix perltidy breaking perlcritic
Date
Msg-id CAFBsxsG4yC4uUM6+fy=0RO0ZE6E=VRFJ6Eu6fBeairBUxtCunQ@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Fix perltidy breaking perlcritic  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Fix perltidy breaking perlcritic  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-committers
On Fri, Sep 9, 2022 at 3:32 AM Andrew Dunstan <andrew@dunslane.net> wrote:

> A better way do do this IMNSHO is to put the eval in a block on its own along with the no critic marker on its own
line,like this:
 
>
> {
>    ## no critic (ProhibitStringyEval)
>    eval ...
> }
>
> perlcritic respects block boundaries for its directives.

I tried that in the attached -- it looks a bit nicer but requires more
explanation. I don't have strong feelings either way.

-- 
John Naylor
EDB: http://www.enterprisedb.com

Attachment

pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: aix: No need to use mkldexport when we want to export all symbol
Next
From: Tom Lane
Date:
Subject: Re: pgsql: aix: No need to use mkldexport when we want to export all symbol