Re: pgsql: Refer to replication origin roident as "ID" in user facing messa - Mailing list pgsql-committers

From John Naylor
Subject Re: pgsql: Refer to replication origin roident as "ID" in user facing messa
Date
Msg-id CAFBsxsEMiQA-HbhcPT=_nqLhAb6YX0mhxr+WQFcuqeMznkew_g@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Refer to replication origin roident as "ID" in user facing messa  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: pgsql: Refer to replication origin roident as "ID" in user facing messa  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-committers
On Thu, Aug 18, 2022 at 4:49 PM Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
>
> On 18.08.22 04:10, John Naylor wrote:
> > While at it, most format strings already use %u, so for consintency
> > change the remaining stragglers using %d.
>
> This is incorrect.  Replication origin IDs are of type uint16, which
> gets promoted to int in a variable arguments list, so %d is the correct
> placeholder.

I would think that for uint16, either %d or %u would have the same
result. Is there some other consideration I'm not aware of?

-- 
John Naylor
EDB: http://www.enterprisedb.com



pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: doc: Improve some markups and some wording around archiving modu
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Move a definition inside a header file