Postgres Pro
Downloads
Home   >   mailing lists

Re: Perform COPY FROM encoding conversions in larger chunks - Mailing list pgsql-hackers

From John Naylor
Subject Re: Perform COPY FROM encoding conversions in larger chunks
Date
Msg-id CAFBsxsE6_Lr+Xk4O+gNWo3aZDRZu=6RsLJ5SoSbTiMQDJxdF9g@mail.gmail.com
Whole thread Raw
In response to Re: Perform COPY FROM encoding conversions in larger chunks  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Perform COPY FROM encoding conversions in larger chunks
List pgsql-hackers
Tree view
On Sun, Feb 7, 2021 at 2:13 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>
> On 02/02/2021 23:42, John Naylor wrote:
> >
> > In copyfromparse.c, this is now out of date:
> >
> >   * Read the next input line and stash it in line_buf, with conversion to
> >   * server encoding.

This comment for CopyReadLine() is still there. Conversion already happened by now, so I think this comment is outdated.

Other than that, I think this is ready for commit.

--
John Naylor
EDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Parallel INSERT (INTO ... SELECT ...)
Next
From: Fujii Masao
Date:
Subject: Re: adding wait_start column to pg_locks