Re: psql tab completion for updatable foreign tables - Mailing list pgsql-hackers

From Samrat Revagade
Subject Re: psql tab completion for updatable foreign tables
Date
Msg-id CAF8Q-Gw0haUA660cxZijE9Bkh2t-0iNd4ULFKRPExc5SdKfKiQ@mail.gmail.com
Whole thread Raw
In response to Re: psql tab completion for updatable foreign tables  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: psql tab completion for updatable foreign tables  (Pavan Deolasee <pavan.deolasee@gmail.com>)
List pgsql-hackers



On Fri, Sep 20, 2013 at 7:54 PM, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
On 20 September 2013 11:29, Samrat Revagade <revagade.samrat@gmail.com> wrote:
>>
>>
>> > Okay, are you adding this to the september commitfest?
>> >
>>
>> OK, I've done that. I think that it's too late for 9.3.
>>
>
>
> +1 for idea.
>
> I have tested patch and got surprising results with Cent-OS
> Patch is working fine for Cent-OS 6.2 and RHEL 6.3
> But is is giving problem on Cent-OS 6.3 (tab complete for local tables but
> not for foreign tables)
>
> I have used following script:
>
> Two postgres  servers are running by using ports 5432 and 5433.
> Server with port 5432 has postgres_fdw installed and will interact with the
> remote server running under port 5433.
>
> psql -p 5433 -c "CREATE TABLE aa_remote (a int, b int)" postgres
> postgres=# CREATE EXTENSION postgres_fdw;
> postgres=# CREATE SERVER postgres_server FOREIGN DATA WRAPPER postgres_fdw
> OPTIONS (host 'localhost', port '5433', dbname 'postgres');
> postgres=# CREATE USER MAPPING FOR PUBLIC SERVER postgres_server OPTIONS
> (password '');
> postgres=# CREATE FOREIGN TABLE aa_foreign (a int, b int) SERVER
> postgres_server OPTIONS (table_name 'aa_remote');
> postgres=# INSERT into aa_foreign values (1,2);
>
> But while doing any operation on aa_foreign tab do not complete on Cent-OS
> 6.3 (tab complete for local tables but not for foreign tables)
> Is that a problem ?
>

Hmm. It works for me. What does pg_relation_is_updatable() return for
your foreign table?



Sorry .my environment has some problem. when I compiled it with fresh installation of  Cent-OS 6.3 it worked.
Patch :
1. Applies cleanly to git master
2. Has necessary source code comments
3. Follows coding standards
4. Solves use case.


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: removing old ports and architectures
Next
From: Andres Freund
Date:
Subject: Re: removing old ports and architectures