Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE - Mailing list pgsql-hackers

Hi Stephen and Thomas,

Thanks your review comments.

Enclosed please find the latest patch.

>/src/backend/parser/gram.y: In function ‘base_yyparse’:

>/src/backend/parser/gram.y:1160:19: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]

>| IN_P DATABASE db_spec_name { $$ = $3; }

The warning has been dismissed.

>When it should be:

>ALTER DATABASE { <replaceable class="parameter">name</replaceable> | CURRENT_DATABASE } OWNER TO { <replaceable>new_owner</replaceable> | CURRENT_USER | SESSION_USER }

Yes. It should be.

>Please don't include whitespace-only hunks, like this one:

Ok.

>The TAP regression tests for pg_dump are failing. 

The test case has been updated.

>make makeDbSpec() return a DbSpec and then try to minimize the

>forced-casting happening.

Makes sense. It has been changed.

Regards,

Jing Wang 

Fujitsu Australia