Re: backup manifests - Mailing list pgsql-hackers

From Suraj Kharage
Subject Re: backup manifests
Date
Msg-id CAF1DzPXcCgXP2awVaH4uHovPo77JdLYPAYShzwnSPMVzdUmxSQ@mail.gmail.com
Whole thread Raw
In response to Re: backup manifests  (Suraj Kharage <suraj.kharage@enterprisedb.com>)
Responses Re: backup manifests
List pgsql-hackers
Hi,
 
I think that what we should actually do here is try to use simplehash.
Right now, it won't work for frontend code, but I posted some patches
to try to address that issue:

https://www.postgresql.org/message-id/CA%2BTgmob8oyh02NrZW%3DxCScB%2B5GyJ-jVowE3%2BTWTUmPF%3DFsGWTA%40mail.gmail.com

That would have a few advantages. One, we wouldn't need to know the
number of elements in advance, because simplehash can grow
dynamically. Two, we could use the iteration interfaces to walk the
hash table.  Your solution to that is pgrhash_seq_search, but that's
actually not well-designed, because it's not a generic iterator
function but something that knows specifically about the 'touch' flag.
I incidentally suggest renaming 'touch' to 'matched;' 'touch' is not
bad, but I think 'matched' will be a little more recognizable.
 
Thanks for the suggestion. Will try to implement the same and update accordingly. 
I am assuming that I need to build the patch based on the changes that you proposed on the mentioned thread.
 

I have implemented the simplehash in backup validator patch as Robert suggested. Please find attached 0002 patch for the same.

kindly review and let me know your thoughts.

Also attached the remaining patches. 0001 and 0003 are same as v2, only patch version is bumped.


--
--

Thanks & Regards, 
Suraj kharage, 
EnterpriseDB Corporation, 
The Postgres Database Company.
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Improve documentation of REINDEX options
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: non-exclusive backup cleanup is mildly broken