Request a Demo
Home   >   mailing lists

Re: Possible replace of strncpy on xactdesc.c - Mailing list pgsql-hackers

From solai v
Subject Re: Possible replace of strncpy on xactdesc.c
Date
Msg-id CAF0whuf52ZnYfaSSn-eexOPWMP4nLiT7=V44S5Rc+kLBtAXduQ@mail.gmail.com
Whole thread
In response to Re: Possible replace of strncpy on xactdesc.c  (Mario González Troncoso <gonzalemario@gmail.com>)
List pgsql-hackers
Tree view 
Hi Mario,

I tested the patch locally.
Before applying the patch, I verified that strncpy() was used in
ParsePrepareRecord() and tested the affected code path by creating and
committing a prepared transaction using PREPARE TRANSACTION. The
prepared transaction appeared correctly in pg_prepared_xacts, and
COMMIT PREPARED completed successfully.

After applying the patch, I rebuilt PostgreSQL and repeated the same
test. The behavior remained unchanged: PREPARE TRANSACTION, COMMIT
PREPARED, and the committed data all worked as expected.
I didn't notice any regressions during my testing. The change looks good to me.

Thanks for the patch!

Regards
Solai

pgsql-hackers by date:

Previous
From: Xuneng Zhou
Date:
Subject: Re: Implement waiting for wal lsn replay: reloaded
Next
From: Michael Paquier
Date:
Subject: Re: Reject ill-formed range bounds histograms in pg_restore_attribute_stats()