Re: Reject ill-formed range bounds histograms in pg_restore_attribute_stats() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Reject ill-formed range bounds histograms in pg_restore_attribute_stats()
Date
Msg-id ak8xbvyBwH0uzOU8@paquier.xyz
Whole thread
In response to Re: Reject ill-formed range bounds histograms in pg_restore_attribute_stats()  (Ewan Young <kdbase.hack@gmail.com>)
List pgsql-hackers
On Wed, Jul 08, 2026 at 12:16:27PM +0800, Ewan Young wrote:
> Done in v2.  I moved the check to stat_utils.c as stats_check_bounds_histogram()
> and now call it from both pg_restore_attribute_stats() and
> pg_restore_extended_stats().  In the extended path I reject an ill-formed
> histogram the same way the sibling stakinds there already do — WARNING plus
> goto pg_statistic_error.

Thanks.  I have simplified some of the very-talkative comments,
adjusted one place where array_in_safe() was not mentioned (for
extstats expressions we rely on it for NULLs), tweaked a few more
minor things and applied on HEAD.

> Agreed — v2 targets master only, no back-branch patches.

If somebody has an argument to make here, please feel free.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: solai v
Date:
Subject: Re: Possible replace of strncpy on xactdesc.c
Next
From: vignesh C
Date:
Subject: Re: PSQL - prevent describe listing tables that are already in listed schemas