Request a Demo
Home   >   mailing lists

Re: Possible replace of strncpy on xactdesc.c - Mailing list pgsql-hackers

From Mario González Troncoso
Subject Re: Possible replace of strncpy on xactdesc.c
Date
Msg-id CAFsReFVg--+gp8T_QzKos6aUPZRfOupBz=d=1sHg2wc8KkO_WQ@mail.gmail.com
Whole thread
In response to Re: Possible replace of strncpy on xactdesc.c  (Mario González Troncoso <gonzalemario@gmail.com>)
Responses Re: Possible replace of strncpy on xactdesc.c
Re: Possible replace of strncpy on xactdesc.c
List pgsql-hackers
Tree view 
On Mon, 6 Jul 2026 at 18:26, Mario González Troncoso
<gonzalemario@gmail.com> wrote:
>
> On Mon, 6 Jul 2026 at 10:38, Daniel Gustafsson <daniel@yesql.se> wrote:
> >
> >
> > As a general rule it's a good idea to replace strncpy with strlcpy.
> >
> > > The other functions that are inside the file already use strlcpy() so
> > > maybe the use of current strncpy() on xactdesc.c is just code that
> > > comes from the refactor itself.
> >
> > It was introduced in 1eb6d6527aae in twophase.c and then moved to xaxtdesc.c in
> > the above mentioned commit.
> >
> > > I'll send a proper patch once some feedback is received but at least
> > > it's compiling and passing local tests.
> >
> > Sounds good, please send a patch.
> >
>
> Great. Sending it now after rebasing from master and passing local
> tests (long live cirrus CI).
>
> I added this to the commitfest as well
> https://commitfest.postgresql.org/patch/6989/
>
> >
>

Hopefully with the patch.

>
> --
> Mario Gonzalez
> EDB: https://www.enterprisedb.com



--
Mario Gonzalez
EDB: https://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Next
From: Andrey Rachitskiy
Date:
Subject: [PATCH] Limit PL/Perl scalar copies to work_mem