Postgres Pro
Downloads
Home   >   mailing lists

Re: use CREATE DATABASE STRATEGY = FILE_COPY in pg_upgrade - Mailing list pgsql-hackers

From Matthias van de Meent
Subject Re: use CREATE DATABASE STRATEGY = FILE_COPY in pg_upgrade
Date
Msg-id CAEze2WjrAvyhwBh=rS+3DK2gpoXNOV-=5YB3APkV=Q3cOtMkVw@mail.gmail.com
Whole thread Raw
In response to Re: use CREATE DATABASE STRATEGY = FILE_COPY in pg_upgrade  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Tree view 
On Fri, 14 Jun 2024 at 23:29, Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Wed, Jun 12, 2024 at 09:41:01AM -0500, Nathan Bossart wrote:
> > Actually, I think you are right that we need a manual checkpoint, except I
> > think we need it to be after prepare_new_globals().  set_frozenxids()
> > connects to each database (including template0) and updates a bunch of
> > pg_class rows, and we probably want those on disk before we start copying
> > the files to create all the user's databases.

Good catch, I hadn't thought of that.

> Here is an updated patch.

LGTM.

Kind regards,

Matthias van de Meent
Neon (https://neon.tech)

pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: Add pg_get_acl() function get the ACL for a database object
Next
From: Robert Haas
Date:
Subject: Re: use CREATE DATABASE STRATEGY = FILE_COPY in pg_upgrade