Re: btree: implement dynamic prefix truncation (was: Improving btree performance through specializing by key shape, take 2) - Mailing list pgsql-hackers

From Matthias van de Meent
Subject Re: btree: implement dynamic prefix truncation (was: Improving btree performance through specializing by key shape, take 2)
Date
Msg-id CAEze2Wiv2f_Y8EjFEXtmQsTKRk2XshCvBkyDzAWLWbqxMeXknA@mail.gmail.com
Whole thread Raw
In response to Re: btree: implement dynamic prefix truncation (was: Improving btree performance through specializing by key shape, take 2)  (Matthias van de Meent <boekewurm+postgres@gmail.com>)
Responses Re: btree: implement dynamic prefix truncation (was: Improving btree performance through specializing by key shape, take 2)
List pgsql-hackers
On Wed, 24 Jan 2024 at 13:02, Matthias van de Meent
<boekewurm+postgres@gmail.com> wrote:
> > 1.
> > Commit message refers to a non-existing reference '(see [0])'.
>
> Noted, I'll update that.
>
> > 2.
> > +When we do a binary search on a sorted set (such as a BTree), we know that a
> > +tuple will be smaller than its left neighbour, and larger than its right
> > +neighbour.
> >
> > I think this should be 'larger than left neighbour and smaller than
> > right neighbour' instead of the other way around.
>
> Noted, will be fixed, too.

Attached is version 15 of this patch, with the above issues fixed.
It's also rebased on top of 655dc310 of this morning, so that should
keep good for some time again.

Kind regards,

Matthias van de Meent
Neon (https://neon.tech)

Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Commitfest Manager for March
Next
From: "Andrey M. Borodin"
Date:
Subject: Re: Commitfest Manager for March