Re: bug: copy progress reporting of backends which run multiple COPYs - Mailing list pgsql-hackers

From Matthias van de Meent
Subject Re: bug: copy progress reporting of backends which run multiple COPYs
Date
Msg-id CAEze2WigStQee9rTzVhwT7HCJRFqKy4pMD1Tf=uF0eXKTezDJA@mail.gmail.com
Whole thread Raw
In response to bug: copy progress reporting of backends which run multiple COPYs  (Justin Pryzby <pryzby@telsasoft.com>)
Responses Re: bug: copy progress reporting of backends which run multiple COPYs
Re: bug: copy progress reporting of backends which run multiple COPYs
List pgsql-hackers
On Thu, 19 Jan 2023 at 06:47, Justin Pryzby <pryzby@telsasoft.com> wrote:
>
> pg_stat_progress_copy was added in v14 (8a4f618e7, 9d2d45700).
>
> But if a command JOINs file_fdw tables, the progress report gets bungled
> up.  This will warn/assert during file_fdw tests.

I don't know what to do with that other than disabling COPY progress
reporting for file_fdw, i.e. calls to BeginCopyFrom that don't supply
a pstate. This is probably the best option, because a table backed by
file_fdw would also interfere with COPY TO's progress reporting.

Attached a patch that solves this specific issue in a
binary-compatible way. I'm not super happy about relying on behavior
of callers of BeginCopyFrom (assuming that users that run copy
concurrently will not provide a ParseState* to BeginCopyFrom), but it
is what it is.

Kind regards,

Matthias van de Meent

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?
Next
From: Ted Yu
Date:
Subject: Re: bug: copy progress reporting of backends which run multiple COPYs