Re: Improvements and additions to COPY progress reporting - Mailing list pgsql-hackers

From Matthias van de Meent
Subject Re: Improvements and additions to COPY progress reporting
Date
Msg-id CAEze2WiTSjepqc-JO29yaydeXdgXeqxJ1Hi-DAMvfzKqnnje2w@mail.gmail.com
Whole thread Raw
In response to Re: Improvements and additions to COPY progress reporting  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: Improvements and additions to COPY progress reporting
List pgsql-hackers
On Thu, 11 Feb 2021 at 15:44, Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
>
> On Thu, Feb 11, 2021, 8:08 PM Josef Šimánek <josef.simanek@gmail.com> wrote:
>> I have split it since it should be the start of progress reporting
>> testing at all. If you better consider this as part of COPY testing,
>> feel free to move it to already existing copy testing related files.
>> There's no real reason to keep it separated if not needed.
>
>
> +1 to move those test cases to existing copy test files.

Thanks for your reviews. PFA v4 of the patchset, in which the tests
are put into copy.sql (well, input/copy.source). This also adds tests
for correctly reporting COPY ... FROM 'file'.

I've changed the notice-alerted format from manually naming each
column to calling to_jsonb and removing the unstable columns from the
reported value; this should therefore be stable and give direct notice
to changes in the view.

With regards,

Matthias van de Meent.

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Next
From: Zhihong Yu
Date:
Subject: Re: Parallel INSERT (INTO ... SELECT ...)