Re: Detoasting optionally to make Explain-Analyze less misleading - Mailing list pgsql-hackers

From Matthias van de Meent
Subject Re: Detoasting optionally to make Explain-Analyze less misleading
Date
Msg-id CAEze2WiLjoAYTcaaSR=pMK1SaZHMDh4Z7yeDeDrk3B7zNVA4gA@mail.gmail.com
Whole thread Raw
In response to Re: Detoasting optionally to make Explain-Analyze less misleading  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: Detoasting optionally to make Explain-Analyze less misleading
List pgsql-hackers
Hi,

I've taken the liberty to update this patch, and register it in the
commitfest app to not lose track of progress [0].

The attached v8 patch measures scratch memory allocations (with MEMORY
option), total time spent in serialization (with TIMING on, measures
are inclusive of unseparated memcpy to the message buffer), and a
count of produced bytes plus the output format used (text or binary).
It's a light rework of the earlier 0007 patch, I've reused tests and
some infrastructure, while the implementation details and comments
have been updated significantly.

I think we can bikeshed on format and names, but overall I think the
patch is in a very decent shape.

Stepan, thank you for your earlier work, and feel free to check it out
or pick it up again if you want to; else I'll try to get this done.

Kind regards,

Matthias van de Meent

[0] https://commitfest.postgresql.org/47/4852/

Attachment

pgsql-hackers by date:

Previous
From: Ivan Trofimov
Date:
Subject: Re: libpq: PQfnumber overload for not null-terminated strings
Next
From: Jeff Davis
Date:
Subject: Re: Comments on Custom RMGRs