Re: XLog size reductions: Reduced XLog record header size for PG17 - Mailing list pgsql-hackers

On Fri, 30 Jun 2023 at 17:36, Matthias van de Meent
<boekewurm+postgres@gmail.com> wrote:
>
> Hi,
>
> The attached v2 patchset contains some small fixes for the failing
> cfbot 32-bit tests - at least locally it does so.
>
> I'd overlooked one remaining use of MAXALIGN64() in xlog.c in the last
> patch of the set, which has now been updated to XLP_ALIGN as well.
> Additionally, XLP_ALIGN has been updated to use TYPEALIGN64 instead of
> TYPEALIGN so that we don't lose bits of the aligned value in 32-bit
> systems.

Apparently there was some usage of MAXALIGN() in xlogreader that I'd
missed, and which only shows up in TAP tests. In v3 I've fixed that,
together with some improved early detection of invalid record headers.

Kind regards,

Matthias van de Meent
Neon (https://neon.tech/)