Re: postgres_fdw: IMPORT FOREIGN SCHEMA ... LIMIT TO (partition) - Mailing list pgsql-hackers

From Matthias van de Meent
Subject Re: postgres_fdw: IMPORT FOREIGN SCHEMA ... LIMIT TO (partition)
Date
Msg-id CAEze2WgjXRVij+romZS-Q50eSoZz1R4e6eZ=njJu-G9DTn+=GQ@mail.gmail.com
Whole thread Raw
In response to Re: postgres_fdw: IMPORT FOREIGN SCHEMA ... LIMIT TO (partition)  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: postgres_fdw: IMPORT FOREIGN SCHEMA ... LIMIT TO (partition)  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Tue, 6 Apr 2021 at 14:29, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>
> Thanks! So I applied all the changes that I suggested upthread to the patch.
> I also updated the comment as follows.
>
>                  * Import table data for partitions only when they are explicitly
> -                * specified in LIMIT TO clause. Otherwise ignore them and
> -                * only include the definitions of the root partitioned tables to
> -                * allow access to the complete remote data set locally in
> -                * the schema imported.
> +                * specified in LIMIT TO clause. Otherwise ignore them and only
> +                * include the definitions of the root partitioned tables to allow
> +                * access to the complete remote data set locally in the schema
> +                * imported.
>
> Attached is the updated version of the patch. Barring any objection,
> I'm thinking to commit this.

Thanks, this was on my to-do list for today, but you were faster.

No objections on my part, and thanks for picking this up.

With regards,

Matthias van de Meent



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit?
Next
From: Michael Paquier
Date:
Subject: Re: postgres_fdw: IMPORT FOREIGN SCHEMA ... LIMIT TO (partition)