Re: two occurrences of assign print_notnull within pg_dump.c - Mailing list pgsql-hackers

On Thu, Apr 3, 2025 at 4:31 PM jian he <jian.universality@gmail.com> wrote:
>
> hi.
>
> in src/bin/pg_dump/pg_dump.c
> within function dumpTableSchema:
> there are two occurrences of:
>                     print_notnull = (tbinfo->notnull_constrs[j] != NULL &&
>                                      (tbinfo->notnull_islocal[j] ||
>                                       dopt->binary_upgrade ||
>                                       tbinfo->ispartition));

The same commit 14e87ffa5c543b5f30ead7413084c25f7735039f modified
existing definition of print_notnull and added another. I wonder why.
- probably just an oversight or define to closer to usage. But we
don't do the latter.

--
Best Wishes,
Ashutosh Bapat