Re: Better shared data structure management and resizable shared data structures - Mailing list pgsql-hackers

On Sun, Apr 5, 2026 at 7:38 PM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> On Sun, Apr 5, 2026 at 11:18 AM Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> >
> >
> > I will post my resizable shmem structures patch in a separate email in
> > this thread but continue to review your patches.
>
> I reviewed the SLRU patch. This is the first time I am looking at SLRU
> code, so my review may not be sufficient. As far as I understand, the
> patch faithfully copies the functionality from the old system to the
> new system. I didn't find any issues there.
>
> I think calls to SimpleLruRequest() reads much better than SimpleLruInit().
>
> Both MultiXactShmemInit and MultiXactShmemAttach set
> OldestMemberMXactId, OldestVisibleMXactId. In future if we add another
> global variable to point to the shared memory, somebody needs to
> remember to initialize it in both these functions. Maybe deduplicate
> it with something like attached? Similarly for PredicateLock related
> changes.

Sorry, I attached the wrong patch. Here's the right patch.

--
Best Wishes,
Ashutosh Bapat