Re: Adding REPACK [concurrently] - Mailing list pgsql-hackers

From Antonin Houska
Subject Re: Adding REPACK [concurrently]
Date
Msg-id 24165.1775406641@localhost
Whole thread Raw
In response to Re: Adding REPACK [concurrently]  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Adding REPACK [concurrently]
List pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:

> On 2026-Apr-05, Antonin Houska wrote:
> 
> > ok, maybe just skip the whole cleanup in that special case.
> 
> Hmm, should we make this test only in the db_specific case?  Doing it
> unconditionally makes me a bit nervous (maybe because I don't fully
> understand historic snapshot building).

I thought about adding Assert(db_specific) in front of the new return
statement. So what you suggest makes sense to me.

As far as I understand, the xl_running_xacts record is not directly involved
in the snapshot build. Rather, the list of XIDs for snapshots is created and
updated by processing COMMIT and ABORT records.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com



pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Better shared data structure management and resizable shared data structures
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: pg_get__*_ddl consolidation